Add support for transects plotted on the native MPAS-Ocean mesh #718
Conversation
|
Hello @xylar! Thanks for updating this PR. We checked the lines you've touched for PEP 8 issues, and found:
Comment last updated at 2021-11-30 14:25:21 UTC |
|
@milenaveneziani, I'm still testing this out. I'll post some results and then ask you to test as well when you have time. |
|
This PR should not be merged until |
xylar
force-pushed
the
native_transects_mpas_tools
branch
from
2346b07 to
2c8fd10
Compare
|
Hey @xylar, I was checking this again and wondered how far you think it is from being a part of MPAS-Analysis, now that so much progress has gone into MPAS-Tools since the past summer. I know you have a lot on your plate right now, but, if you think the effort on your side is small, I would be willing to do some extensive testing. |
|
@milenaveneziani, thanks for checking on this. My recollection is that the results were still buggy when I check on them and I had the impression that there would be several days of effort needed to get it working. It hasn't been a top priority for me since then. I'd love to have these but making them robust is likely to take a bit of effort over a couple of months. But I'll make sure this gets back onto my to-do list as soon as the new compass is merged in, in couple of weeks to a month. |
|
No worries @xylar. Your last comment in August made me (wishfully :) think that this was closer to being ready. Definitely not a priority at the moment. |
This will make it easier to support native MPAS grids in future plots.
Plotting is now with tripcolor, tricontour and tricontourf. This will allow generalization to plots where triangulation is done ahead of time, e.g. for sections on the native MPAS mesh.
The coordinates are now keyword arguments since they are optional.
This is just for more convenient imports
* Pass arguments to create a triangulation rather than requiring a specific form for a data set * Update how outlines are handled if passed in as arguments
xylar
force-pushed
the
native_transects_mpas_tools
branch
from
2c8fd10 to
a5b08b4
Compare
Substantial changes are made to how transects are computed and plotted to accommondate this move.
xylar
force-pushed
the
native_transects_mpas_tools
branch
from
a5b08b4 to
005a43c
Compare
|
@milenaveneziani, this is ready for you to try out if you have time. It would be great to include it in the next version, even if we don't use it by default. |
|
I'm going to merge this, with the plan that we will further test it as part of E3SM-Unified testing. |
|
sorry @xylar, I missed the notification for this one. This is great news! |
This merge adds support for using MPAS-Tools to compute transects on the native MPAS-Ocean mesh. Observations are interpolated to the MPAS transect so comparison can also take place on this mesh.
Major changes are made to how vertical sections are plotted, making a
matplotlib.tri.Triangulationfrom the logically rectangular grids we have used so far so that we can optionally pass the arguments needed to create a triangulation on the native MPAS mesh. The approach of outlining the valid region of the transect using a contour also no longer works with the native triangulation, so coordinates for producing an outline can optionally be passed in instead.The
mpasnative grid has been made the default inconfigs/polarRegions.conf.closes #586